[FE] 페어 목록 리스트 구현 #117
Merged
[FE] 페어 목록 리스트 구현 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dle234
approved these changes
Jul 25, 2024
| const [isOpen, setIsOpen] = useState(false); | ||
|
|
||
| const onCopy = () => { | ||
| window.navigator.clipboard.writeText(roomCode); |
There was a problem hiding this comment.
생락하면 계속 오류가 발생하더라구요 ㅠㅠ
일단은 이대로 유지하겠습니다 😢
anttiey
approved these changes
Jul 25, 2024
| } | ||
|
|
||
| const Header = ({ isOpen }: HeaderProps) => ( | ||
| <S.Layout icon={<IoPeople color={theme.color.primary[500]} />} title={isOpen ? '페어' : ''} /> |
There was a problem hiding this comment.
저희 디자인이 닫혀 있는 상태가 기본이 되도록 변경된 만큼, 사이드 바에 마우스를 올리면 열 수 있다는 표시가 들어가는 것도 좋을 것 같다는 생각이에요. 피그마 디자인처럼 닫혀 있는 상태에서는 아이콘이 > 화살표로 변경되는 건 어떤가요?
| @@ -0,0 +1,29 @@ | |||
| import styled from 'styled-components'; | |||
There was a problem hiding this comment.
저희 피그마 시안에는 border 가 있는데 제공해 주신 영상은 피그마 시안과 다른 것처럼 보여요. 혹시 다르게 디자인이 된 이유가 있나요?
There was a problem hiding this comment.
isOpen때 border가 조금 짧아서 보류하고 있었어요. 반영했습니다 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
페어 목록 리스트 구현
상세 설명
마우스를 올리면 open, 마우스 내리면 close
2024-07-24.9.50.11.mov